Bug 149260

Summary: Remove XHR_TIMEOUT compilation guard
Product: WebKit Reporter: youenn fablet <youennf>
Component: XMLAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2015-09-17 06:35:09 PDT
We should remove XHR_TIMEOUT compilation guard and rename didTimeout as didReachTimeout.
Attachments
Patch (45.40 KB, patch)
2015-09-17 06:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (45.51 KB, patch)
2015-09-20 02:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-09-17 06:46:36 PDT
Created attachment 261390 [details] Patch
Csaba Osztrogonác
Comment 2 2015-09-17 08:39:21 PDT
Comment on attachment 261390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261390&action=review If we remove a compile time guard we should propose it on webkit-dev mailing list. > Tools/Scripts/webkitperl/FeatureList.pm:-456 > - { option => "xhr-timeout", desc => "Toggle XHR Timeout support", > - define => "ENABLE_XHR_TIMEOUT", default => (isEfl() || isGtk() || isAppleMacWebKit()), value => \$xhrTimeoutSupport }, > - Please remove xhrTimeoutSupport variable in line 151.
Benjamin Poulain
Comment 3 2015-09-18 14:47:11 PDT
Comment on attachment 261390 [details] Patch I don't know anything about this code but Alexey would have protested by now if there were issues :)
youenn fablet
Comment 4 2015-09-20 02:35:02 PDT
Thanks for the reviews. > I don't know anything about this code but Alexey would have protested by now > if there were issues :) I should have mentionned this was discussed as part of bug 98156. ap agreed to remove it. > Please remove xhrTimeoutSupport variable in line 151. OK
youenn fablet
Comment 5 2015-09-20 02:36:07 PDT
Created attachment 261609 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-09-20 03:30:23 PDT
Comment on attachment 261609 [details] Patch for landing Clearing flags on attachment: 261609 Committed r190025: <http://trac.webkit.org/changeset/190025>
WebKit Commit Bot
Comment 7 2015-09-20 03:30:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.