Bug 149258

Summary: REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
[Patch] Proposed Fix
none
WIP
nvasilyev: review-, nvasilyev: commit-queue-
WIP
nvasilyev: review-, nvasilyev: commit-queue-
Patch
timothy: review+
Patch none

Nikita Vasilyev
Reported 2015-09-17 06:04:03 PDT
Created attachment 261388 [details] [Animated GIF] Bug Steps: 1. Open http://www.apple.com 2. Inspect <body> 3. In the right sidebar, select "Styles — Rules" 4. Type "color" inside the Styles Attribute section Actual: DOM path bar blinks on every key stroke. Expected: DOM path bar shouldn't blink.
Attachments
[Animated GIF] Bug (76.19 KB, image/gif)
2015-09-17 06:04 PDT, Nikita Vasilyev 		no flags
Details
[Patch] Proposed Fix (1.79 KB, patch)
2015-10-27 14:24 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
WIP (1.77 KB, patch)
2016-05-09 15:42 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
WIP (4.62 KB, patch)
2016-05-09 15:43 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Patch (3.24 KB, patch)
2016-05-09 16:44 PDT, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2016-05-09 17:25 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-17 06:04:33 PDT
<rdar://problem/22737843>
Timothy Hatcher
Comment 2 2015-09-17 08:46:47 PDT
This might be a regression caused by switching to requestAnimationFrame for updateLayoutSoon.
Blaze Burg
Comment 3 2015-09-17 09:27:45 PDT
Heh, I was just going to file this bug, but my video clip got buried somewhere.
Matt Baker
Comment 4 2015-10-25 00:05:46 PDT
(In reply to comment #2) > This might be a regression caused by switching to requestAnimationFrame for > updateLayoutSoon. Good call! I caused this regression in http://trac.webkit.org/changeset/188494. The flashing as the navigation bar updates is also visible when selecting nodes in the DOM tree content view. Working on a fix.
Matt Baker
Comment 5 2015-10-27 14:24:49 PDT
Created attachment 264159 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 6 2015-10-27 14:43:07 PDT
Comment on attachment 264159 [details] [Patch] Proposed Fix Clearing flags on attachment: 264159 Committed r191640: <http://trac.webkit.org/changeset/191640>
WebKit Commit Bot
Comment 7 2015-10-27 14:43:12 PDT
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 8 2015-12-20 01:23:42 PST
The problem still persists on r194173. (Should I reopen bugs for cases like this?)
Nikita Vasilyev
Comment 9 2016-05-09 15:42:08 PDT
Created attachment 278447 [details] WIP This fixed the issue when the the DOM path bar isn't very long, e.g. the nesting isn't very deep. I'm not sure what difference does it make. I'm continuing looking.
Nikita Vasilyev
Comment 10 2016-05-09 15:43:13 PDT
Created attachment 278448 [details] WIP
Nikita Vasilyev
Comment 11 2016-05-09 16:44:40 PDT
Created attachment 278459 [details] Patch
Timothy Hatcher
Comment 12 2016-05-09 17:01:17 PDT
Comment on attachment 278459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278459&action=review > Source/WebInspectorUI/ChangeLog:10 > + (value): Should fix the name here.
Timothy Hatcher
Comment 13 2016-05-09 17:03:44 PDT
Comment on attachment 278459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278459&action=review >> Source/WebInspectorUI/ChangeLog:10 >> + (value): > > Should fix the name here. Should fix the name here. > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js:77 > + _componentsEqual(a, b) > + { > + let getRepresentedObjects = (component) => component.representedObject; > + > + let representedObjectsA = a.map(getRepresentedObjects); > + let representedObjectsB = b.map(getRepresentedObjects); > + return Array.shallowEqual(representedObjectsA, representedObjectsB); > + } This method has a underscore, but it is in the Public section. It should move to the Private section or, since it is only used once, inlined next to the caller above.
Nikita Vasilyev
Comment 14 2016-05-09 17:12:30 PDT
With the last patch the icons on the right are still blinking. I need to combine my two latest patches into one.
Nikita Vasilyev
Comment 15 2016-05-09 17:25:11 PDT
Created attachment 278463 [details] Patch Not setting r+ since there are more changes.
WebKit Commit Bot
Comment 16 2016-05-09 18:39:39 PDT
Comment on attachment 278463 [details] Patch Clearing flags on attachment: 278463 Committed r200605: <http://trac.webkit.org/changeset/200605>
WebKit Commit Bot
Comment 17 2016-05-09 18:39:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.