Bug 149255

Summary: Delete some dead code
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Tim Horton
Reported 2015-09-17 02:39:20 PDT
Delete some dead code
Attachments
Patch (4.83 KB, patch)
2015-09-17 02:39 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.86 KB, patch)
2015-09-17 02:48 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-09-17 02:39:41 PDT
Created attachment 261381 [details] Patch
Tim Horton
Comment 2 2015-09-17 02:44:13 PDT
Comment on attachment 261381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261381&action=review > Source/WebCore/platform/network/mac/CookieJarMac.mm:-145 > - return false; Oh, this is probably the what-happens-if-an-exception-is-thrown case (looking at what the exception blocking macros actually do). But I'm not sure why it's not a compilation error to not have this, because it seems like that would imply not having a return statement in the case that the exception is thrown...
Tim Horton
Comment 3 2015-09-17 02:48:11 PDT
Created attachment 261384 [details] Patch
Tim Horton
Comment 4 2015-09-17 03:00:57 PDT
(In reply to comment #2) > Comment on attachment 261381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261381&action=review > > > Source/WebCore/platform/network/mac/CookieJarMac.mm:-145 > > - return false; > > Oh, this is probably the what-happens-if-an-exception-is-thrown case > (looking at what the exception blocking macros actually do). But I'm not > sure why it's not a compilation error to not have this, because it seems > like that would imply not having a return statement in the case that the > exception is thrown... Yeah... seems like that's just a missing warning (even -Weverything doesn't catch it in a silly test app).
Tim Horton
Comment 5 2015-09-17 12:00:54 PDT
http://trac.webkit.org/changeset/189921
Note You need to log in before you can comment on or make changes to this bug.