| Summary: | Delete some dead code | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | mitz | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2015-09-17 02:39:20 PDT
Created attachment 261381 [details]
Patch
Comment on attachment 261381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261381&action=review > Source/WebCore/platform/network/mac/CookieJarMac.mm:-145 > - return false; Oh, this is probably the what-happens-if-an-exception-is-thrown case (looking at what the exception blocking macros actually do). But I'm not sure why it's not a compilation error to not have this, because it seems like that would imply not having a return statement in the case that the exception is thrown... Created attachment 261384 [details]
Patch
(In reply to comment #2) > Comment on attachment 261381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261381&action=review > > > Source/WebCore/platform/network/mac/CookieJarMac.mm:-145 > > - return false; > > Oh, this is probably the what-happens-if-an-exception-is-thrown case > (looking at what the exception blocking macros actually do). But I'm not > sure why it's not a compilation error to not have this, because it seems > like that would imply not having a return statement in the case that the > exception is thrown... Yeah... seems like that's just a missing warning (even -Weverything doesn't catch it in a silly test app). |