Bug 149222
| Summary: | webkit-patch rollout should not die when passed a unicode character in the message | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | achristensen, ap, dbates, ddkilzer, jhoneycutt, joepeck, lforschler, rniwa |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Blaze Burg
This most often manifests as webkitbot refusing to do a rollout:
09:53 <alexchristensen> webkitbot: rollout 189851 189853 didn’t actually fix permissions issue
09:53 <webkitbot> alexchristensen: Preparing rollout for http://trac.webkit.org/changeset/189851 and http://trac.webkit.org/changeset/189853 ...
09:53 <webkitbot> Exception executing command: 'ascii' codec can't decode byte 0xe2 in position 4: ordinal not in range(128)
I added a parse test to irc_command_unittests.py to verify that the problem is not specific to the IRC bot's parser. It probably happens somewhere deeper in the rollout command.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alex Christensen
I wondered why it failed. I didn't see the ’ in didn’t. That's annoying.