Bug 149174

Summary:

[WebGL] Only require that the stencil value and write masks have as many bits set as the stencil buffer is deep

Product:

WebKit

Reporter:

Jinyoung Hur <hur.ims>

Component:

WebGL

Assignee:

Jinyoung Hur <hur.ims>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jinyoung Hur 2015-09-15 11:28:38 PDT

Regarding the stencil mask value tests, fast/canvas/webgl/gl-get-calls.html seems obsolete compared to webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html.

Comment 1 Jinyoung Hur 2015-09-15 11:35:09 PDT

Created attachment 261220 [details]
Patch

Comment 2 Jinyoung Hur 2015-09-15 11:53:28 PDT

Copied from the webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html.
https://github.com/KhronosGroup/WebGL/commit/b540926f97e5566d4d5fbdc3539ff19910734f7e

It seems that there is a difference in the way that glGetIntegerV returns an unsigned int type value among OpenGL implementatios.
Some return the whole bits of value(e.g., 0xffffffff -> 0xffffffff), whereas some(e.g., ANGLE) return a max-int-clamped value(e.g., 0xffffffff -> 0x7fffffff).

It would be good to make this test independent on the OpenGL implementations.

Comment 3 WebKit Commit Bot 2015-09-15 18:55:01 PDT

Comment on attachment 261220 [details]
Patch

Clearing flags on attachment: 261220

Committed r189838: <http://trac.webkit.org/changeset/189838>

Comment 4 WebKit Commit Bot 2015-09-15 18:55:05 PDT

All reviewed patches have been landed.  Closing bug.