Bug 149150

Summary: Web Inspector: Watch Expressions uncaught exceptions on page reload
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-09-14 21:01:16 PDT
* SUMMARY Watch Expressions uncaught exceptions on page reload. * STEPS TO REPRODUCE 1. Add "document.activeElement" watch expression 2. Pause in some script 3. Reload => Error logged to console * NOTES - Because DebuggerManager.Resume does not trigger immediately, the activeCallFrame is invalid when re-evaluating the watch expressions. - We should immediately Resume when main frame changes instead of waiting for the 50ms delay (which already causes some problems)
Attachments
[PATCH] Proposed Fix (6.14 KB, patch)
2015-09-14 21:04 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-09-14 21:04:05 PDT
Created attachment 261168 [details] [PATCH] Proposed Fix
Radar WebKit Bug Importer
Comment 2 2015-09-14 21:05:02 PDT
<rdar://problem/22696954>
Radar WebKit Bug Importer
Comment 3 2015-09-14 21:05:20 PDT
<rdar://problem/22696963>
Blaze Burg
Comment 4 2015-09-15 09:09:00 PDT
Comment on attachment 261168 [details] [PATCH] Proposed Fix r=me Is this too flaky to test?
Joseph Pecoraro
Comment 5 2015-09-15 10:19:24 PDT
(In reply to comment #4) > Comment on attachment 261168 [details] > [PATCH] Proposed Fix > > r=me > > Is this too flaky to test? Not flakey, just the Watch Expressions stuff is refreshed in view code.
WebKit Commit Bot
Comment 6 2015-09-15 11:36:18 PDT
Comment on attachment 261168 [details] [PATCH] Proposed Fix Clearing flags on attachment: 261168 Committed r189816: <http://trac.webkit.org/changeset/189816>
WebKit Commit Bot
Comment 7 2015-09-15 11:36:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.