Summary: | [ES6] Add more fine-grained APIs and additional hooks to control module loader from WebCore | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 147340, 148897 | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2015-09-14 14:34:21 PDT
Created attachment 261135 [details]
Patch
Created attachment 261366 [details]
Patch
More clean up
Comment on attachment 261366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261366&action=review r=me with comment > Source/JavaScriptCore/builtins/ModuleLoaderObject.js:541 > +function prepareModuleGraph(moduleName, referrer) I think we need a better name for this, maybe: "loadAndExecuteModule" or "loadAndEvaluateModule"? Or something that indicates execution better than "prepare". I don't think "graph" is needed in the name. Comment on attachment 261366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261366&action=review Thank you for your review! >> Source/JavaScriptCore/builtins/ModuleLoaderObject.js:541 >> +function prepareModuleGraph(moduleName, referrer) > > I think we need a better name for this, maybe: "loadAndExecuteModule" or "loadAndEvaluateModule"? > Or something that indicates execution better than "prepare". I don't think "graph" is needed in the name. After discussing with you on IRC, I'll rename APIs. prepareModuleGraph => loadModule, loadModuleGraph => loadAndEvaluateModule, and linkAndEvaluateModuleGraph => linkAndEvaluateModule Committed r189941: <http://trac.webkit.org/changeset/189941> |