Bug 149123

Summary: Progress towards cmake on mac
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, mrobinson
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch cdumez: review+, cdumez: commit-queue-

Description Alex Christensen 2015-09-14 11:33:03 PDT 
I made a lot of progress.
Comment 1 Alex Christensen 2015-09-14 11:46:43 PDT 
Created attachment 261118 [details]
Patch
Comment 2 Alex Christensen 2015-09-14 12:12:16 PDT 
Created attachment 261119 [details]
Patch
Comment 3 Alex Christensen 2015-09-14 12:25:49 PDT 
Created attachment 261120 [details]
Patch
Comment 4 Alex Christensen 2015-09-14 12:55:10 PDT 
Created attachment 261122 [details]
Patch
Comment 5 Alex Christensen 2015-09-14 13:23:29 PDT 
Created attachment 261126 [details]
Patch
Comment 6 Chris Dumez 2015-09-14 14:12:39 PDT 
Comment on attachment 261126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261126&action=review

rs=me with comments.

> Source/WebCore/CMakeLists.txt:267
> +    Modules/plugins/QuickTimePluginReplacement.idl

This should be Mac-specific.

> Source/WebCore/rendering/CounterNode.cpp:83
> +                    if (nextSibling)

Why this change?
Comment 7 Alex Christensen 2015-09-14 14:23:41 PDT 
(In reply to comment #6)
> Comment on attachment 261126 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261126&action=review
> 
> rs=me with comments.
> 
> > Source/WebCore/CMakeLists.txt:267
> > +    Modules/plugins/QuickTimePluginReplacement.idl
> 
> This should be Mac-specific.
Skipped for now.
> 
> > Source/WebCore/rendering/CounterNode.cpp:83
> > +                    if (nextSibling)
> 
> Why this change?
This is related to another patch.  I didn't commit it.

http://trac.webkit.org/changeset/189749