Summary: | [GTK] media controls does not show up when playing video finishes. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <changseok> | ||||||||
Component: | WebKitGTK | Assignee: | ChangSeok Oh <changseok> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, cgarcia, clopez, commit-queue, gustavo, pnormand | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 149151 | ||||||||||
Bug Blocks: | 149396 | ||||||||||
Attachments: |
|
Description
ChangSeok Oh
2015-09-13 22:10:49 PDT
Created attachment 261169 [details]
Patch
Created attachment 261173 [details]
Patch
Xabier wdyt about this patch? (In reply to comment #3) > Xabier wdyt about this patch? At a first glance it looks ok. I don't know why but I cannot render any page with video so I cannot give the patch a try. Tests need to run smoothly without any change and some smoke testing needs to be done with both audio only and video to ensure nothing is broken. That code is quite delicate :) (In reply to comment #4) > (In reply to comment #3) > > Xabier wdyt about this patch? > > At a first glance it looks ok. > > I don't know why but I cannot render any page with video so I cannot give > the patch a try. > > Tests need to run smoothly without any change and some smoke testing needs > to be done with both audio only and video to ensure nothing is broken. That > code is quite delicate :) FYI, I'm trying to fix the existing issues for media controls. This is a series patch. Please consider bug149111, bug149113 as well. =) Created attachment 261299 [details]
Patch
Comment on attachment 261299 [details]
Patch
Here we go!
Comment on attachment 261299 [details] Patch Clearing flags on attachment: 261299 Committed r190054: <http://trac.webkit.org/changeset/190054> All reviewed patches have been landed. Closing bug. You missed to update some baselines after this changes. I have done that on http://trac.webkit.org/changeset/193853 |