Bug 149110

Summary: [EFL] Remove create() factory function in EvasGLContext and EvasGLSurface
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-09-13 22:00:55 PDT
It is not good implementation we support both create() factory function and public constructor. In EvasGLContext case, it has supported both. However create() factory is only used by EwkView. Thus remove the create() function, then EwkView creates EvasGLContext using std::make_unique<> directly.
Attachments
Patch (3.80 KB, patch)
2015-09-13 22:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (5.70 KB, patch)
2015-09-13 22:10 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (5.80 KB, patch)
2015-09-13 22:19 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-09-13 22:03:18 PDT
Created attachment 261100 [details] Patch
Gyuyoung Kim
Comment 2 2015-09-13 22:10:22 PDT
Created attachment 261101 [details] Patch
WebKit Commit Bot
Comment 3 2015-09-13 22:13:08 PDT
Attachment 261101 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 4 2015-09-13 22:19:27 PDT
Created attachment 261102 [details] Patch
WebKit Commit Bot
Comment 5 2015-09-14 06:55:24 PDT
Comment on attachment 261102 [details] Patch Clearing flags on attachment: 261102 Committed r189728: <http://trac.webkit.org/changeset/189728>
WebKit Commit Bot
Comment 6 2015-09-14 06:55:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.