Bug 149110

Summary: [EFL] Remove create() factory function in EvasGLContext and EvasGLSurface
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Gyuyoung Kim 2015-09-13 22:00:55 PDT 
It is not good implementation we support both create() factory function and public constructor. In EvasGLContext case, it has supported both. However create() factory is only used by EwkView. Thus remove the create() function, then EwkView creates EvasGLContext using std::make_unique<> directly.
Comment 1 Gyuyoung Kim 2015-09-13 22:03:18 PDT 
Created attachment 261100 [details]
Patch
Comment 2 Gyuyoung Kim 2015-09-13 22:10:22 PDT 
Created attachment 261101 [details]
Patch
Comment 3 WebKit Commit Bot 2015-09-13 22:13:08 PDT 
Attachment 261101 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gyuyoung Kim 2015-09-13 22:19:27 PDT 
Created attachment 261102 [details]
Patch
Comment 5 WebKit Commit Bot 2015-09-14 06:55:24 PDT 
Comment on attachment 261102 [details]
Patch

Clearing flags on attachment: 261102

Committed r189728: <http://trac.webkit.org/changeset/189728>
Comment 6 WebKit Commit Bot 2015-09-14 06:55:28 PDT 
All reviewed patches have been landed.  Closing bug.