Bug 149077

Summary:

Still need view snapshotting code for non-IOSurface for the sim

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, thorton

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Beth Dakin 2015-09-11 15:26:05 PDT

l need view snapshotting code for non-IOSurface for the sim

Comment 1 Beth Dakin 2015-09-11 15:27:08 PDT

Created attachment 261021 [details]
Patch

Comment 2 WebKit Commit Bot 2015-09-11 15:27:57 PDT

Attachment 261021 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:150:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2015-09-11 15:30:15 PDT

Comment on attachment 261021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261021&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:570
> +#if USE(IOSURFACE)

No need. This is always true on Mac.

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:819
> +#if USE(IOSURFACE)

No need. This is always true on Mac.

Comment 4 Beth Dakin 2015-09-11 15:33:44 PDT

Thanks! http://trac.webkit.org/changeset/189635

Comment 5 Beth Dakin 2015-09-11 16:06:32 PDT

Build fix: http://trac.webkit.org/changeset/189637