Bug 149022

Summary: [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, ddkilzer, glenn
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Andy Estes
Reported 2015-09-09 18:14:15 PDT
[iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
Attachments
Patch (4.97 KB, patch)
2015-09-09 18:27 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (4.97 KB, patch)
2015-09-09 18:29 PDT, Andy Estes 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2015-09-09 18:27:41 PDT
Created attachment 260898 [details] Patch
Andy Estes
Comment 2 2015-09-09 18:29:48 PDT
Created attachment 260900 [details] Patch
Daniel Bates
Comment 3 2015-09-09 19:27:48 PDT
Comment on attachment 260900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260900&action=review > Tools/Scripts/webkitpy/xcode/simulator.py:237 > +# Also, simctl has the option to output in JSON format (xcrun simctl list --json). Yes, we want to make use of this. > Tools/Scripts/webkitpy/xcode/simulator.py:246 > + '(i|watch)OS (?P<version>[0-9]+\.[0-9])(?P<internal> Internal)? \([0-9]+\.[0-9]+(\.[0-9]+)? - (?P<build_version>[^)]+)\) \((?P<identifier>[^)]+)\)( \((?P<availability>[^)]+)\))?') We could simplify this regular expression by making use of the special sequence \d := [0-9]. See <https://docs.python.org/2/howto/regex.html> for more details.
Andy Estes
Comment 4 2015-09-10 10:30:33 PDT
Committed r189573: <http://trac.webkit.org/changeset/189573>
David Kilzer (:ddkilzer)
Comment 5 2016-06-25 08:10:18 PDT
*** Bug 159116 has been marked as a duplicate of this bug. ***
David Kilzer (:ddkilzer)
Comment 6 2016-06-25 08:10:59 PDT
<rdar://problem/21787528>
Note You need to log in before you can comment on or make changes to this bug.