Summary: | [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, dbates, ddkilzer, glenn | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andy Estes
2015-09-09 18:14:15 PDT
Created attachment 260898 [details]
Patch
Created attachment 260900 [details]
Patch
Comment on attachment 260900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260900&action=review > Tools/Scripts/webkitpy/xcode/simulator.py:237 > +# Also, simctl has the option to output in JSON format (xcrun simctl list --json). Yes, we want to make use of this. > Tools/Scripts/webkitpy/xcode/simulator.py:246 > + '(i|watch)OS (?P<version>[0-9]+\.[0-9])(?P<internal> Internal)? \([0-9]+\.[0-9]+(\.[0-9]+)? - (?P<build_version>[^)]+)\) \((?P<identifier>[^)]+)\)( \((?P<availability>[^)]+)\))?') We could simplify this regular expression by making use of the special sequence \d := [0-9]. See <https://docs.python.org/2/howto/regex.html> for more details. Committed r189573: <http://trac.webkit.org/changeset/189573> *** Bug 159116 has been marked as a duplicate of this bug. *** |