Bug 149022 - [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
Summary: [iOS] Teach run-webkit-tests how to parse simulator runtimes when version num...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
: 159116 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-09 18:14 PDT by Andy Estes
Modified: 2016-06-25 08:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2015-09-09 18:27 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (4.97 KB, patch)
2015-09-09 18:29 PDT, Andy Estes 		dbates: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-09-09 18:14:15 PDT 
[iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers  contain a revision
Comment 1 Andy Estes 2015-09-09 18:27:41 PDT 
Created attachment 260898 [details]
Patch
Comment 2 Andy Estes 2015-09-09 18:29:48 PDT 
Created attachment 260900 [details]
Patch
Comment 3 Daniel Bates 2015-09-09 19:27:48 PDT 
Comment on attachment 260900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260900&action=review

> Tools/Scripts/webkitpy/xcode/simulator.py:237
> +#        Also, simctl has the option to output in JSON format (xcrun simctl list --json).

Yes, we want to make use of this.

> Tools/Scripts/webkitpy/xcode/simulator.py:246
> +        '(i|watch)OS (?P<version>[0-9]+\.[0-9])(?P<internal> Internal)? \([0-9]+\.[0-9]+(\.[0-9]+)? - (?P<build_version>[^)]+)\) \((?P<identifier>[^)]+)\)( \((?P<availability>[^)]+)\))?')

We could simplify this regular expression by making use of the special sequence \d := [0-9]. See <https://docs.python.org/2/howto/regex.html> for more details.
Comment 4 Andy Estes 2015-09-10 10:30:33 PDT 
Committed r189573: <http://trac.webkit.org/changeset/189573>
Comment 5 David Kilzer (:ddkilzer) 2016-06-25 08:10:18 PDT 
*** Bug 159116 has been marked as a duplicate of this bug. ***
Comment 6 David Kilzer (:ddkilzer) 2016-06-25 08:10:59 PDT 
<rdar://problem/21787528>