Summary: | Implement internal calls in WebAssembly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sukolsak Sakshuwong <sukolsak> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mark.lam, saam, sukolsak | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 146064 | ||||||
Attachments: |
|
Description
Sukolsak Sakshuwong
2015-09-09 01:38:47 PDT
Created attachment 260849 [details]
Patch
Comment on attachment 260849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685 > + Vector<CallCompilationInfo> m_callCompilationInfo; You need to do something to GC this correctly. See our other handling of CallLinkInfo. Comment on attachment 260849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review >> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:685 >> + Vector<CallCompilationInfo> m_callCompilationInfo; > > You need to do something to GC this correctly. See our other handling of CallLinkInfo. I think he's doing it right already. The CallLinkInfos get added to a CodeBlock. The CodeBlock then knows what to do. Comment on attachment 260849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260849&action=review > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:642 > + CallLinkInfo* info = m_codeBlock->addCallLinkInfo(); I see. Is good. Comment on attachment 260849 [details]
Patch
LGTM.
Comment on attachment 260849 [details] Patch Clearing flags on attachment: 260849 Committed r189563: <http://trac.webkit.org/changeset/189563> All reviewed patches have been landed. Closing bug. Comment on attachment 260849 [details]
Patch
r=me
|