Bug 148997

Summary: http/tests/xmlhttprequest/ontimeout-response-getters.html is flaky
Product: WebKit Reporter: youenn fablet <youennf>
Component: XMLAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2015-09-09 00:28:35 PDT 
As pointed out by ap (https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=xmlhttprequest%2Fontimeout-response-getters)  http/tests/xmlhttprequest/ontimeout-response-getters.html is flaky.
This may be related to http://trac.webkit.org/changeset/189445
Comment 1 youenn fablet 2015-09-09 00:32:44 PDT 
Created attachment 260847 [details]
Patch
Comment 2 youenn fablet 2015-09-09 00:34:00 PDT 
(In reply to comment #1)
> Created attachment 260847 [details]
> Patch

Lets' try augmenting the network time it takes to receive the HTTP response so that XHR timeout has more chances to kick in.
Comment 3 youenn fablet 2015-09-09 11:41:14 PDT 
Given the size of the patch, it might be ok to commit it as unreviewed.
I'll do that tomorrow in case no review happens.
Comment 4 Alexey Proskuryakov 2015-09-09 12:36:59 PDT 
Comment on attachment 260847 [details]
Patch

This kind of change generally does require review - even when the patch is obviously right, another purpose of review is that someone else knows what's going on.
Comment 5 WebKit Commit Bot 2015-09-09 13:29:27 PDT 
Comment on attachment 260847 [details]
Patch

Clearing flags on attachment: 260847

Committed r189545: <http://trac.webkit.org/changeset/189545>
Comment 6 WebKit Commit Bot 2015-09-09 13:29:31 PDT 
All reviewed patches have been landed.  Closing bug.