Bug 148997 - http/tests/xmlhttprequest/ontimeout-response-getters.html is flaky
Summary: http/tests/xmlhttprequest/ontimeout-response-getters.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-09 00:28 PDT by youenn fablet
Modified: 2015-09-09 13:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2015-09-09 00:32 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-09-09 00:28:35 PDT 
As pointed out by ap (https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=xmlhttprequest%2Fontimeout-response-getters)  http/tests/xmlhttprequest/ontimeout-response-getters.html is flaky.
This may be related to http://trac.webkit.org/changeset/189445
Comment 1 youenn fablet 2015-09-09 00:32:44 PDT 
Created attachment 260847 [details]
Patch
Comment 2 youenn fablet 2015-09-09 00:34:00 PDT 
(In reply to comment #1)
> Created attachment 260847 [details]
> Patch

Lets' try augmenting the network time it takes to receive the HTTP response so that XHR timeout has more chances to kick in.
Comment 3 youenn fablet 2015-09-09 11:41:14 PDT 
Given the size of the patch, it might be ok to commit it as unreviewed.
I'll do that tomorrow in case no review happens.
Comment 4 Alexey Proskuryakov 2015-09-09 12:36:59 PDT 
Comment on attachment 260847 [details]
Patch

This kind of change generally does require review - even when the patch is obviously right, another purpose of review is that someone else knows what's going on.
Comment 5 WebKit Commit Bot 2015-09-09 13:29:27 PDT 
Comment on attachment 260847 [details]
Patch

Clearing flags on attachment: 260847

Committed r189545: <http://trac.webkit.org/changeset/189545>
Comment 6 WebKit Commit Bot 2015-09-09 13:29:31 PDT 
All reviewed patches have been landed.  Closing bug.