Bug 148995

Summary: sendProcessWillSuspendImminently uses a wrong message flag
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, dbates
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+, ap: commit-queue-

Alexey Proskuryakov
Reported 2015-09-08 23:10:37 PDT
WebProcessProxy::sendProcessWillSuspendImminently (and its NetworkProcess counterpart) passes IPC::InterruptWaitingIfSyncMessageArrives to sendSync, but this value can only be used with waitForMessage. Not sure if this is a real bug - this flag gets interpreted as IPC::InformPlatformProcessWillSuspend, which may or may not be what we are after here. This code was added in http://trac.webkit.org/r184105
Attachments
Patch (1.70 KB, patch)
2015-09-10 12:32 PDT, Daniel Bates 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-09-10 12:32:22 PDT
Created attachment 260940 [details] Patch
Alexey Proskuryakov
Comment 2 2015-09-10 12:51:34 PDT
Comment on attachment 260940 [details] Patch Looks good, however please make the same fix in NetworkProcessProxy.
Daniel Bates
Comment 3 2015-09-10 13:13:09 PDT
(In reply to comment #2) > Comment on attachment 260940 [details] > Patch > > Looks good, however please make the same fix in NetworkProcessProxy. Will fix before landing.
Daniel Bates
Comment 4 2015-09-10 13:14:05 PDT
Committed r189587: <http://trac.webkit.org/changeset/189587>
Note You need to log in before you can comment on or make changes to this bug.