Bug 148959

Summary: document.importNode(node, deep): deep's default value should be false
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#dom-document-importnode
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-09-08 09:07:58 PDT
document.importNode(node, deep): deep's default value should be false:
https://dom.spec.whatwg.org/#interface-document
https://dom.spec.whatwg.org/#dom-document-importnode

Firefox and Chrome follow the specification. However, WebKit uses "true" for deep's default value.

Note that WebKit use to have "false" as default value but this was changed in Bug 71190 because the DOM spec said to use "false" at the time :(
Comment 1 Chris Dumez 2015-09-08 09:08:48 PDT
rdar://problem/22558915
Comment 2 Chris Dumez 2015-09-08 09:51:37 PDT
Created attachment 260765 [details]
Patch
Comment 3 WebKit Commit Bot 2015-09-08 12:39:50 PDT
Comment on attachment 260765 [details]
Patch

Clearing flags on attachment: 260765

Committed r189502: <http://trac.webkit.org/changeset/189502>
Comment 4 WebKit Commit Bot 2015-09-08 12:39:54 PDT
All reviewed patches have been landed.  Closing bug.