Bug 148955

Summary: [JSC] Weak should only accept cell pointees.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: REOPENED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149456    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-09-08 08:10:17 PDT
JSC::WeakImpl already asserts that the weak pointee is a non-null JSCell*. We should enforce this at compile time with narrower types.
Attachments
Patch (96.95 KB, patch)
2015-09-08 08:20 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-09-08 08:20:51 PDT
Created attachment 260760 [details] Patch
Geoffrey Garen
Comment 2 2015-09-10 17:52:10 PDT
Comment on attachment 260760 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-09-11 02:16:49 PDT
Comment on attachment 260760 [details] Patch Clearing flags on attachment: 260760 Committed r189616: <http://trac.webkit.org/changeset/189616>
WebKit Commit Bot
Comment 4 2015-09-11 02:16:58 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2015-09-22 05:17:14 PDT
Re-opened since this is blocked by bug 149456
Note You need to log in before you can comment on or make changes to this bug.