Bug 148955

Summary: [JSC] Weak should only accept cell pointees.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: REOPENED ---    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149456    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Andreas Kling 2015-09-08 08:10:17 PDT 
JSC::WeakImpl already asserts that the weak pointee is a non-null JSCell*. We should enforce this at compile time with narrower types.
Comment 1 Andreas Kling 2015-09-08 08:20:51 PDT 
Created attachment 260760 [details]
Patch
Comment 2 Geoffrey Garen 2015-09-10 17:52:10 PDT 
Comment on attachment 260760 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-09-11 02:16:49 PDT 
Comment on attachment 260760 [details]
Patch

Clearing flags on attachment: 260760

Committed r189616: <http://trac.webkit.org/changeset/189616>
Comment 4 WebKit Commit Bot 2015-09-11 02:16:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2015-09-22 05:17:14 PDT 
Re-opened since this is blocked by bug 149456