Bug 148908

Summary: Simplify JIT::emit_op_mod()
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, msaboff, saam, sukolsak
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Sukolsak Sakshuwong 2015-09-06 02:39:27 PDT 
The IDIV instruction on x86 divides the value in the EDX:EAX registers by the source operand and stores the quotient in EAX and the remainder in EDX. Therefore, we store the values that we don't want to be overwritten by IDIV in registers that are not EAX or EDX. This patch makes the intention clearer and makes the code easier to read.
Comment 1 Sukolsak Sakshuwong 2015-09-06 02:41:23 PDT 
Created attachment 260708 [details]
Patch
Comment 2 Michael Saboff 2015-09-06 03:03:44 PDT 
Comment on attachment 260708 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-09-06 07:38:20 PDT 
Comment on attachment 260708 [details]
Patch

Clearing flags on attachment: 260708

Committed r189444: <http://trac.webkit.org/changeset/189444>
Comment 4 WebKit Commit Bot 2015-09-06 07:38:23 PDT 
All reviewed patches have been landed.  Closing bug.