Bug 148908

Summary: Simplify JIT::emit_op_mod()
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, msaboff, saam, sukolsak
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sukolsak Sakshuwong
Reported 2015-09-06 02:39:27 PDT
The IDIV instruction on x86 divides the value in the EDX:EAX registers by the source operand and stores the quotient in EAX and the remainder in EDX. Therefore, we store the values that we don't want to be overwritten by IDIV in registers that are not EAX or EDX. This patch makes the intention clearer and makes the code easier to read.
Attachments
Patch (2.01 KB, patch)
2015-09-06 02:41 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-06 02:41:23 PDT
Created attachment 260708 [details] Patch
Michael Saboff
Comment 2 2015-09-06 03:03:44 PDT
Comment on attachment 260708 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-09-06 07:38:20 PDT
Comment on attachment 260708 [details] Patch Clearing flags on attachment: 260708 Committed r189444: <http://trac.webkit.org/changeset/189444>
WebKit Commit Bot
Comment 4 2015-09-06 07:38:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.