Summary: | Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, bdakin, mmaxfield, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2015-09-05 15:14:43 PDT
Created attachment 260702 [details]
Patch
Myles, you might want to have a peek at the WKTR bit. Comment on attachment 260702 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260702&action=review > Tools/WebKitTestRunner/TestController.cpp:821 > + return false; Perhaps this should cause a parse error > LayoutTests/swipe/main-frame-pinning-requirement.html:2 > +<!-- This test has to use threaded scrolling because we don't I generally like to put this explanatory text in the markup itself so if you just load up the test you know what's going on. > LayoutTests/swipe/main-frame-pinning-requirement.html:15 > + eventSender.mouseMoveTo(100, 100); Don't you have to skip this on iOS? > LayoutTests/swipe/main-frame-pinning-requirement.html:66 > + shouldBe(false, eventQueue.hasPendingEvents(), "Event queue should be empty. Both scroll events should be required to start the swipe because of the swipe-start hysteresis."); Why don't these log when they pass? Also isn't there a shouldBeFalse()? |