Bug 148857

Summary:

bgsound should use HTMLUnknownElement interface

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Patch	none

Ryosuke Niwa

Reported 2015-09-04 17:24:36 PDT

See https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis "The blink, bgsound, isindex, multicol, nextid, rb, and spacer elements must use the HTMLUnknownElement interface." This bug was found by the newly added: LayoutTests/http/tests/w3c/html/semantics/interfaces.html

Attachments
Patch (14.12 KB, patch) 2015-10-20 16:48 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (864.85 KB, application/zip) 2015-10-20 17:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1012.46 KB, application/zip) 2015-10-20 17:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (837.00 KB, application/zip) 2015-10-20 17:35 PDT, Build Bot	no flags	Details
Patch (10.08 KB, patch) 2015-10-20 21:25 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (647.87 KB, application/zip) 2015-10-20 22:07 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (723.32 KB, application/zip) 2015-10-20 22:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (777.24 KB, application/zip) 2015-10-20 22:19 PDT, Build Bot	no flags	Details
Patch (6.49 KB, patch) 2015-10-21 09:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2015-09-04 17:55:19 PDT

<rdar://problem/22589036>

Chris Dumez

Comment 2 2015-10-20 16:40:44 PDT

Firefox: bgsound -> HTMLUnknownElement rb -> HTMLElement Chrome: bgsound -> HTMLUnknownElement rb -> HTMLUnknownElement Safari: bgsound -> HTMLElement rb -> HTMLElement Spec: bgsound -> HTMLUnknownElement rb -> HTMLUnknownElement

Chris Dumez

Comment 3 2015-10-20 16:48:55 PDT

Created attachment 263635 [details] Patch

Build Bot

Comment 4 2015-10-20 17:24:51 PDT

Comment on attachment 263635 [details] Patch Attachment 263635 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/313660 New failing tests: fast/css/bidi-override-in-anonymous-block.html html5lib/generated/run-tests25-write.html html5lib/generated/run-ruby-write.html html5lib/generated/run-tests19-write.html html5lib/generated/run-ruby-data.html html5lib/generated/run-tests25-data.html html5lib/generated/run-tests19-data.html

Build Bot

Comment 5 2015-10-20 17:24:56 PDT

Created attachment 263638 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 6 2015-10-20 17:35:05 PDT

Comment on attachment 263635 [details] Patch Attachment 263635 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/313656 New failing tests: fast/css/bidi-override-in-anonymous-block.html html5lib/generated/run-tests25-write.html html5lib/generated/run-ruby-write.html html5lib/generated/run-tests19-write.html html5lib/generated/run-ruby-data.html html5lib/generated/run-tests25-data.html html5lib/generated/run-tests19-data.html

Build Bot

Comment 7 2015-10-20 17:35:08 PDT

Created attachment 263641 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2015-10-20 17:35:13 PDT

Comment on attachment 263635 [details] Patch Attachment 263635 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/313686 New failing tests: fast/css/bidi-override-in-anonymous-block.html html5lib/generated/run-tests25-write.html html5lib/generated/run-ruby-write.html html5lib/generated/run-tests19-write.html html5lib/generated/run-ruby-data.html html5lib/generated/run-tests25-data.html html5lib/generated/run-tests19-data.html

Build Bot

Comment 9 2015-10-20 17:35:17 PDT

Created attachment 263642 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Ryosuke Niwa

Comment 10 2015-10-20 17:47:54 PDT

I'm not sure if we want to change the interface of rb. WHATWG spec is "wrong" in that we would want to keep supporting rb in the parser for compatibility reasons.

Chris Dumez

Comment 11 2015-10-20 21:25:50 PDT

Created attachment 263656 [details] Patch

Build Bot

Comment 12 2015-10-20 22:07:05 PDT

Comment on attachment 263656 [details] Patch Attachment 263656 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/314531 New failing tests: html5lib/generated/run-tests25-write.html html5lib/generated/run-tests19-write.html html5lib/generated/run-tests25-data.html html5lib/generated/run-tests19-data.html

Build Bot

Comment 13 2015-10-20 22:07:12 PDT

Created attachment 263658 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 14 2015-10-20 22:12:54 PDT

Comment on attachment 263656 [details] Patch Attachment 263656 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/314539 New failing tests: html5lib/generated/run-tests25-write.html html5lib/generated/run-tests19-write.html html5lib/generated/run-tests25-data.html html5lib/generated/run-tests19-data.html

Build Bot

Comment 15 2015-10-20 22:12:59 PDT

Created attachment 263659 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 16 2015-10-20 22:19:40 PDT

Comment on attachment 263656 [details] Patch Attachment 263656 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/314543 New failing tests: html5lib/generated/run-tests25-write.html html5lib/generated/run-tests19-write.html html5lib/generated/run-tests25-data.html html5lib/generated/run-tests19-data.html

Build Bot

Comment 17 2015-10-20 22:19:44 PDT

Created attachment 263660 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 18 2015-10-21 09:42:36 PDT

Created attachment 263685 [details] Patch

Chris Dumez

Comment 19 2015-10-21 09:43:51 PDT

Comment on attachment 263685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263685&action=review > Source/WebCore/html/HTMLTagNames.in:21 > +bgsound interfaceName=HTMLUnknownElement I chose a more conservative approach, similar to the one used in Blink. Our parser is still aware of bgsound with this change.

WebKit Commit Bot

Comment 20 2015-10-21 13:04:54 PDT

Comment on attachment 263685 [details] Patch Clearing flags on attachment: 263685 Committed r191398: <http://trac.webkit.org/changeset/191398>

WebKit Commit Bot

Comment 21 2015-10-21 13:05:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.