Bug 148853

Summary: embed element without src and type attributes should represent nothing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Plug-insAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bdakin, cfleizach, commit-queue, dmazzoni, esprehn+autocc, gyuyoung.kim, jcraig, jdiggs, jer.noble, koivisto, mario, rniwa, samuel_white, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
Attachments:
Description Flags
WIP Patch
none
Patch none

Chris Dumez
Reported 2015-09-04 16:54:28 PDT
embed element without src and type attributes should represent nothing [1]: """ While any of the following conditions are occurring, any plugin instantiated for the element must be removed, and the embed element represents nothing: - The element has neither a src attribute nor a type attribute. - The element has a media element ancestor. - The element has an ancestor object element that is not showing its fallback content. """ Currently, WebKit renders such embed. This is causing the following newly imported W3C tests to fail: http/tests/w3c/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-01.html http/tests/w3c/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html [1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element
Attachments
WIP Patch (9.51 KB, patch)
2015-11-06 15:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.17 KB, patch)
2015-11-06 16:21 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-09-04 17:14:22 PDT
rdar://problem/22588235
Chris Dumez
Comment 2 2015-11-06 15:39:37 PST
Created attachment 264966 [details] WIP Patch
Chris Dumez
Comment 3 2015-11-06 16:21:40 PST
Created attachment 264974 [details] Patch
WebKit Commit Bot
Comment 4 2015-11-07 15:48:06 PST
Comment on attachment 264974 [details] Patch Clearing flags on attachment: 264974 Committed r192132: <http://trac.webkit.org/changeset/192132>
WebKit Commit Bot
Comment 5 2015-11-07 15:48:14 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7 2015-11-07 22:06:45 PST
(In reply to comment #6) > It looks like it broke > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Freplaced%2Freplaced-breaking.html I'll take a look.
Chris Dumez
Comment 8 2015-11-07 22:19:20 PST
(In reply to comment #7) > (In reply to comment #6) > > It looks like it broke > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=fast%2Freplaced%2Freplaced-breaking.html > > I'll take a look. It is odd. The test has a slightly different output on ElCapitan/WK1 only.
Note You need to log in before you can comment on or make changes to this bug.