Bug 148848 – Add a layout test for https://bugs.webkit.org/show_bug.cgi?id=148845

• Component: SVG
• Status: RESOLVED INVALID

[Said Abou-Hallawa]

Add the test case attached to https://bugs.webkit.org/show_bug.cgi?id=148845 as LayoutTests/svg/as-image/svg-cached-no-intrinsic-size-draw-canvas.html. Add this test to LayoutTests/TestExpectations and mark it [ Failure ].

[Said Abou-Hallawa]

Created attachment 260662 [details]
Patch

[Darin Adler]

Comment on attachment 260662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260662&action=review

> LayoutTests/ChangeLog:8
> +        Add the layout test and mark it as failed in TestExpectations.

Why? That’s not usually how we do these things.

[Said Abou-Hallawa]

(In reply to comment #2)
> Comment on attachment 260662 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260662&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Add the layout test and mark it as failed in TestExpectations.
> 
> Why? That’s not usually how we do these things.

My purpose of this patch was to submit the test case even if I do not have the fix ready. For me usually writing the test usually takes more time than fixing the code. 
But I agree I should not do thing differently. So I am closing this bug as WONTFIX. Fixing the other bug  https://bugs.webkit.org/show_bug.cgi?id=148845 should include both the fix and the test case.