Bug 148809

Summary: swipe-start-hysteresis-failures is flaky
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Tim Horton
Reported 2015-09-04 12:00:52 PDT
swipe-start-hysteresis-failures is flaky
Attachments
Patch (2.51 KB, patch)
2015-09-04 12:01 PDT, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-09-04 12:01:14 PDT
Created attachment 260606 [details] Patch
Alexey Proskuryakov
Comment 2 2015-09-04 12:03:08 PDT
Comment on attachment 260606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260606&action=review > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70 > + shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.") I don't see this new shouldBe in expected results.
Tim Horton
Comment 3 2015-09-04 12:20:35 PDT
(In reply to comment #2) > Comment on attachment 260606 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260606&action=review > > > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70 > > + shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.") > > I don't see this new shouldBe in expected results. Hmm, my shouldBe only logs if it fails. Maybe I should change that.
Tim Horton
Comment 5 2015-09-04 23:54:05 PDT
I did. http://trac.webkit.org/changeset/189370
Note You need to log in before you can comment on or make changes to this bug.