| Summary: | swipe-start-hysteresis-failures is flaky | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | Tools / Tests | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-09-04 12:00:52 PDT
Created attachment 260606 [details]
Patch
Comment on attachment 260606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260606&action=review > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70 > + shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.") I don't see this new shouldBe in expected results. (In reply to comment #2) > Comment on attachment 260606 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260606&action=review > > > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70 > > + shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.") > > I don't see this new shouldBe in expected results. Hmm, my shouldBe only logs if it fails. Maybe I should change that. http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=swipe-start-hysteresis-failures Please land? |