Bug 148805

Summary: Import new multicolumn layout tests from CSS WG tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, commit-queue, hyatt, jonlee, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148806    
Attachments:
Description Flags
Imports tests
none
Patch for landing rniwa: commit-queue+

Ryosuke Niwa
Reported 2015-09-04 10:54:52 PDT
Import tests in https://github.com/w3c/csswg-test/tree/master/css-multicol-1
Attachments
Imports tests (628.27 KB, patch)
2015-09-04 11:20 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (628.26 KB, patch)
2015-09-04 11:28 PDT, Ryosuke Niwa 		rniwa: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-09-04 11:20:53 PDT
Created attachment 260602 [details] Imports tests
Radar WebKit Bug Importer
Comment 2 2015-09-04 11:21:38 PDT
<rdar://problem/22580772>
Chris Dumez
Comment 3 2015-09-04 11:26:35 PDT
Comment on attachment 260602 [details] Imports tests r=me if EWS is happy.
Ryosuke Niwa
Comment 4 2015-09-04 11:28:14 PDT
Created attachment 260604 [details] Patch for landing
Ryosuke Niwa
Comment 5 2015-09-04 11:44:33 PDT
Committed r189364: <http://trac.webkit.org/changeset/189364>
Ryosuke Niwa
Comment 6 2015-09-04 14:14:37 PDT
Committed r189387: <http://trac.webkit.org/changeset/189387>
Alexey Proskuryakov
Comment 7 2015-09-04 23:23:45 PDT
imported/w3c/css/css-multicol-1/multicol-span-all-001.xht fails on Windows. Could you please take a look? https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r189367%20(53869)/imported/w3c/css/css-multicol-1/multicol-span-all-001-diffs.html
Chris Dumez
Comment 8 2015-09-05 10:46:44 PDT
(In reply to comment #7) > imported/w3c/css/css-multicol-1/multicol-span-all-001.xht fails on Windows. > Could you please take a look? > > https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/ > r189367%20(53869)/imported/w3c/css/css-multicol-1/multicol-span-all-001- > diffs.html Marked as failing on Windows in <https://trac.webkit.org/r189436>. This is a ref-test with an off-by one pixel issue. The output looks good overall (difficult to tell the difference).
Carlos Alberto Lopez Perez
Comment 9 2015-09-07 08:01:38 PDT
Some of this tests fail on the GTK port. Reported that on bug 148932
Carlos Alberto Lopez Perez
Comment 10 2015-09-07 08:13:55 PDT
(In reply to comment #9) > Some of this tests fail on the GTK port. Reported that on bug 148932 Sorry, I got wrong the bug number. I reported this on bug 148933
Note You need to log in before you can comment on or make changes to this bug.