Summary: | Implement the division and modulo instructions in WebAssembly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sukolsak Sakshuwong <sukolsak> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mark.lam, msaboff, saam, sukolsak, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 148772 | ||||||||
Bug Blocks: | 146064 | ||||||||
Attachments: |
|
Description
Sukolsak Sakshuwong
2015-09-04 02:19:13 PDT
Created attachment 260580 [details]
Patch
Comment on attachment 260580 [details]
Patch
r=me
I believe you should be able to do an inline div on armvs7 and arm64 as well.
Created attachment 260641 [details]
Patch
Update to ToT and add the following line to WASMFunctionCompiler::buildBinaryI32() (division instructions): "// FIXME: We should be able to do an inline div on ARMv7 and ARM64."
Attachment 260641 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:333: JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 260641 [details]
Patch
r=me
Comment on attachment 260641 [details] Patch Clearing flags on attachment: 260641 Committed r189405: <http://trac.webkit.org/changeset/189405> All reviewed patches have been landed. Closing bug. |