Bug 148791

Summary: Implement the division and modulo instructions in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, msaboff, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148772    
Bug Blocks: 146064    
Attachments:
Description Flags
Patch
ggaren: review+
Patch none

Sukolsak Sakshuwong
Reported 2015-09-04 02:19:13 PDT
Implement the division and modulo instructions for WebAssembly files generated by pack-asmjs <https://github.com/WebAssembly/polyfill-prototype-1>.
Attachments
Patch (13.77 KB, patch)
2015-09-04 02:37 PDT, Sukolsak Sakshuwong 		ggaren: review+
DetailsFormatted DiffDiff
Patch (14.08 KB, patch)
2015-09-04 16:14 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-04 02:37:42 PDT
Created attachment 260580 [details] Patch
Geoffrey Garen
Comment 2 2015-09-04 13:55:08 PDT
Comment on attachment 260580 [details] Patch r=me I believe you should be able to do an inline div on armvs7 and arm64 as well.
Sukolsak Sakshuwong
Comment 3 2015-09-04 16:14:23 PDT
Created attachment 260641 [details] Patch Update to ToT and add the following line to WASMFunctionCompiler::buildBinaryI32() (division instructions): "// FIXME: We should be able to do an inline div on ARMv7 and ARM64."
WebKit Commit Bot
Comment 4 2015-09-04 16:16:52 PDT
Attachment 260641 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:333: JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2015-09-04 16:26:06 PDT
Comment on attachment 260641 [details] Patch r=me
WebKit Commit Bot
Comment 6 2015-09-04 17:14:28 PDT
Comment on attachment 260641 [details] Patch Clearing flags on attachment: 260641 Committed r189405: <http://trac.webkit.org/changeset/189405>
WebKit Commit Bot
Comment 7 2015-09-04 17:14:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.