Bug 148786

Summary:

Web Inspector: Add tests for DOM highlight commands

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks	none
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-09-03 21:59:39 PDT

* SUMMARY Add tests for DOM highlight commands. DOM.highlightRect DOM.highlightQuad DOM.highlightNode DOM.highlightFrame DOM.highlightSelector DOM.hideHighlight There was already a test for highlightSelector, I will port that to the new test suite approach. Writing tests caught a few issues, including one affecting highlightQuad/Rect when using usePageCoordinates.

Attachments
[PATCH] Proposed Fix (75.95 KB, patch) 2015-09-03 22:01 PDT, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (665.25 KB, application/zip) 2015-09-03 22:16 PDT, Build Bot	no flags	Details
[PATCH] Proposed Fix (76.85 KB, patch) 2015-09-03 23:13 PDT, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (546.51 KB, application/zip) 2015-09-03 23:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (702.35 KB, application/zip) 2015-09-04 00:10 PDT, Build Bot	no flags	Details
[PATCH] Proposed Fix (76.88 KB, patch) 2015-09-04 13:50 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-09-03 22:00:04 PDT

<rdar://problem/22572509>

Joseph Pecoraro

Comment 2 2015-09-03 22:01:22 PDT

Created attachment 260565 [details] [PATCH] Proposed Fix

Build Bot

Comment 3 2015-09-03 22:16:17 PDT

Comment on attachment 260565 [details] [PATCH] Proposed Fix Attachment 260565 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/138726 New failing tests: inspector/dom/highlightNode.html inspector/dom/highlightSelector.html inspector/dom/hideHighlight.html

Build Bot

Comment 4 2015-09-03 22:16:21 PDT

Created attachment 260567 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Joseph Pecoraro

Comment 5 2015-09-03 23:13:23 PDT

Created attachment 260570 [details] [PATCH] Proposed Fix

Build Bot

Comment 6 2015-09-03 23:45:36 PDT

Comment on attachment 260570 [details] [PATCH] Proposed Fix Attachment 260570 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/138947 New failing tests: inspector/dom/hideHighlight.html

Build Bot

Comment 7 2015-09-03 23:45:40 PDT

Created attachment 260573 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 8 2015-09-04 00:09:59 PDT

Comment on attachment 260570 [details] [PATCH] Proposed Fix Attachment 260570 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/138988 New failing tests: swipe/swipe-start-hysteresis-failures.html

Build Bot

Comment 9 2015-09-04 00:10:02 PDT

Created attachment 260574 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Joseph Pecoraro

Comment 10 2015-09-04 13:50:30 PDT

Created attachment 260613 [details] [PATCH] Proposed Fix Stabilize tests by giving explicit sizes to the targeted and logged elements.

WebKit Commit Bot

Comment 11 2015-09-04 19:38:50 PDT

Comment on attachment 260613 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260613 Committed r189416: <http://trac.webkit.org/changeset/189416>

WebKit Commit Bot

Comment 12 2015-09-04 19:38:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.