Bug 148783

Summary: Unify symbolTableGet and Put in JSLexicalEnvironment and JSSymbolTableObject
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2015-09-03 21:16:35 PDT
They are almost identical.
Attachments
Patch (23.08 KB, patch)
2015-09-08 16:14 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-09-08 16:14:30 PDT
Created attachment 260804 [details] Patch
Yusuke Suzuki
Comment 2 2015-09-08 16:18:21 PDT
Comment on attachment 260804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260804&action=review > Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:-55 > - slot.setValue(this, DontEnum, result); The only difference is here. JSLexicalEnvironment::symbolTableGet always produced the slot with DontEnum. But I don't think it is intentionally used behavior. > Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:-111 > -inline bool JSLexicalEnvironment::symbolTablePutWithAttributes(VM& vm, PropertyName propertyName, JSValue value, unsigned attributes) Not used.
Geoffrey Garen
Comment 3 2015-09-08 17:14:43 PDT
Comment on attachment 260804 [details] Patch r=me
Yusuke Suzuki
Comment 4 2015-09-08 17:22:19 PDT
Comment on attachment 260804 [details] Patch Thanks!
WebKit Commit Bot
Comment 5 2015-09-08 18:33:01 PDT
Comment on attachment 260804 [details] Patch Clearing flags on attachment: 260804 Committed r189525: <http://trac.webkit.org/changeset/189525>
WebKit Commit Bot
Comment 6 2015-09-08 18:33:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.