Bug 148783

Summary: Unify symbolTableGet and Put in JSLexicalEnvironment and JSSymbolTableObject
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Yusuke Suzuki 2015-09-03 21:16:35 PDT 
They are almost identical.
Comment 1 Yusuke Suzuki 2015-09-08 16:14:30 PDT 
Created attachment 260804 [details]
Patch
Comment 2 Yusuke Suzuki 2015-09-08 16:18:21 PDT 
Comment on attachment 260804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260804&action=review

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:-55
> -    slot.setValue(this, DontEnum, result);

The only difference is here. JSLexicalEnvironment::symbolTableGet always produced the slot with DontEnum.
But I don't think it is intentionally used behavior.

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:-111
> -inline bool JSLexicalEnvironment::symbolTablePutWithAttributes(VM& vm, PropertyName propertyName, JSValue value, unsigned attributes)

Not used.
Comment 3 Geoffrey Garen 2015-09-08 17:14:43 PDT 
Comment on attachment 260804 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2015-09-08 17:22:19 PDT 
Comment on attachment 260804 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2015-09-08 18:33:01 PDT 
Comment on attachment 260804 [details]
Patch

Clearing flags on attachment: 260804

Committed r189525: <http://trac.webkit.org/changeset/189525>
Comment 6 WebKit Commit Bot 2015-09-08 18:33:04 PDT 
All reviewed patches have been landed.  Closing bug.