| Summary: | Web Inspector: jsmin.py mistakenly removes whitespace from template literal strings | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=148726 | ||||||||||
| Bug Depends on: | 148730 | ||||||||||
| Bug Blocks: | 148726 | ||||||||||
| Attachments: |
|
||||||||||
I tested upstream jsmin.py 2.1.4, and by adding '`' to quote_chars, there are no longer any test regressions caused by stripping whitespace from template literal strings. Created attachment 260460 [details]
Proposed Fix
Does not apply, depends on jsmin update.
Comment on attachment 260460 [details]
Proposed Fix
r=me
Marked WONTFIX because upstream jsmin regresses and is unable to minify other inspector code. Looking for other alternative. Found a fix for our current jsmin.py. Created attachment 264238 [details]
Patch
Comment on attachment 264238 [details]
Patch
r=me!
Comment on attachment 264238 [details] Patch Clearing flags on attachment: 264238 Committed r191692: <http://trac.webkit.org/changeset/191692> All reviewed patches have been landed. Closing bug. |
Created attachment 260451 [details] testcase Running the following on the test case: $ python ./Source/WebInspectorUI/Scripts/jsmin.py < ~/Desktop/testcases/console-log-template-literal-string.html Produces the following output: <!doctype html><html><body onload="runTest()"><script>function runTest() {let foo=42;console.log(`My favorite number is:${foo}`);}</script><p>To reproduce the bug,try to minify this page.</p></body></html>