Bug 148728

Summary: Web Inspector: jsmin.py mistakenly removes whitespace from template literal strings
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=148726
Bug Depends on: 148730    
Bug Blocks: 148726    
Attachments:
Description Flags
testcase
none
Proposed Fix
none
Patch none

Blaze Burg
Reported 2015-09-02 16:24:15 PDT
Created attachment 260451 [details] testcase Running the following on the test case: $ python ./Source/WebInspectorUI/Scripts/jsmin.py < ~/Desktop/testcases/console-log-template-literal-string.html Produces the following output: <!doctype html><html><body onload="runTest()"><script>function runTest() {let foo=42;console.log(`My favorite number is:${foo}`);}</script><p>To reproduce the bug,try to minify this page.</p></body></html>
Attachments
testcase (232 bytes, text/html)
2015-09-02 16:24 PDT, Blaze Burg 		no flags
Details
Proposed Fix (2.76 KB, patch)
2015-09-02 17:51 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2015-10-28 13:28 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-02 16:25:25 PDT
<rdar://problem/22548921>
Blaze Burg
Comment 2 2015-09-02 16:44:30 PDT
I tested upstream jsmin.py 2.1.4, and by adding '`' to quote_chars, there are no longer any test regressions caused by stripping whitespace from template literal strings.
Blaze Burg
Comment 3 2015-09-02 17:51:08 PDT
Created attachment 260460 [details] Proposed Fix Does not apply, depends on jsmin update.
Joseph Pecoraro
Comment 4 2015-09-02 18:04:53 PDT
Comment on attachment 260460 [details] Proposed Fix r=me
Blaze Burg
Comment 5 2015-10-28 13:13:44 PDT
Marked WONTFIX because upstream jsmin regresses and is unable to minify other inspector code. Looking for other alternative.
Timothy Hatcher
Comment 6 2015-10-28 13:25:30 PDT
Found a fix for our current jsmin.py.
Timothy Hatcher
Comment 7 2015-10-28 13:28:22 PDT
Created attachment 264238 [details] Patch
Joseph Pecoraro
Comment 8 2015-10-28 13:31:40 PDT
Comment on attachment 264238 [details] Patch r=me!
WebKit Commit Bot
Comment 9 2015-10-28 14:18:34 PDT
Comment on attachment 264238 [details] Patch Clearing flags on attachment: 264238 Committed r191692: <http://trac.webkit.org/changeset/191692>
WebKit Commit Bot
Comment 10 2015-10-28 14:18:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.