Bug 148724 – [iOS] Playback does not pause when deselecting route and locking screen.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[iOS] Playback does not pause when deselecting route and locking screen.

[Jer Noble]

<rdar://problem/22100651>

[Jer Noble]

Created attachment 260449 [details]
Patch

[Eric Carlson]

Comment on attachment 260449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260449&action=review

> Source/WebCore/html/MediaElementSession.cpp:295
> +    bool oldHasActiveRoute = m_playbackTarget && m_playbackTarget->hasActiveRoute();
> +    bool newHasActiveRoute = device->hasActiveRoute();
>      m_playbackTarget = WTF::move(device);
>      client().setWirelessPlaybackTarget(*m_playbackTarget.copyRef());
> +    if (oldHasActiveRoute != newHasActiveRoute)
> +        isPlayingToWirelessPlaybackTargetChanged(newHasActiveRoute);

as discussed on irc, this isn't correct or necessary for iOS.

> Source/WebCore/platform/audio/PlatformMediaSessionManager.h:61
> +    bool isApplicationInBackground() const { return m_isApplicationInBackground; }

Nit: this isn't used.

[Jer Noble]

Created attachment 260453 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 260453 [details]
Patch for landing

Clearing flags on attachment: 260453

Committed r189322: <http://trac.webkit.org/changeset/189322>