Bug 148700

Summary: [Mac] Add support for testing swipes
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, bfulgham, buildbot, commit-queue, mitz, qianlangchen, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch again for ews
none
Patch
none
Archive of layout-test-results from ews100 for mac-mavericks
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Patch
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Patch
bdakin: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-mavericks-wk2 none

Tim Horton
Reported 2015-09-01 19:31:40 PDT
[Mac] Add support for testing swipes
Attachments
Patch (42.00 KB, patch)
2015-09-01 19:32 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch again for ews (42.00 KB, patch)
2015-09-02 22:56 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (44.76 KB, patch)
2015-09-02 23:54 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-mavericks (545.90 KB, application/zip)
2015-09-03 00:27 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (585.40 KB, application/zip)
2015-09-03 00:34 PDT, Build Bot 		no flags
Details
Patch (53.30 KB, patch)
2015-09-03 11:23 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (616.40 KB, application/zip)
2015-09-03 12:03 PDT, Build Bot 		no flags
Details
Patch (56.85 KB, patch)
2015-09-03 13:26 PDT, Tim Horton 		bdakin: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (590.85 KB, application/zip)
2015-09-03 14:04 PDT, Build Bot 		no flags
Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-09-01 19:32:14 PDT
Created attachment 260402 [details] Patch
Tim Horton
Comment 2 2015-09-01 19:32:44 PDT
This probably won't build because it depends on https://bugs.webkit.org/show_bug.cgi?id=148693
Tim Horton
Comment 3 2015-09-01 19:33:24 PDT
Need to test on some other version of OS X (Mavericks?) and also make it possible to toggle swipe on/off from JS (because now it's hard-coded to on).
Tim Horton
Comment 4 2015-09-02 22:56:23 PDT
Created attachment 260489 [details] patch again for ews
WebKit Commit Bot
Comment 5 2015-09-02 22:59:31 PDT
Attachment 260489 [details] did not pass style-queue: ERROR: Tools/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 6 2015-09-02 23:54:58 PDT
Created attachment 260492 [details] Patch
Build Bot
Comment 7 2015-09-03 00:27:16 PDT
Comment on attachment 260492 [details] Patch Attachment 260492 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/135628 New failing tests: swipe/basic-cached-back-swipe.html
Build Bot
Comment 8 2015-09-03 00:27:21 PDT
Created attachment 260493 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 9 2015-09-03 00:34:08 PDT
Comment on attachment 260492 [details] Patch Attachment 260492 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/135639 New failing tests: swipe/basic-cached-back-swipe.html
Build Bot
Comment 10 2015-09-03 00:34:13 PDT
Created attachment 260494 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Tim Horton
Comment 11 2015-09-03 11:23:21 PDT
Created attachment 260497 [details] Patch
Build Bot
Comment 12 2015-09-03 12:03:44 PDT
Comment on attachment 260497 [details] Patch Attachment 260497 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/137132 New failing tests: swipe/basic-cached-back-swipe.html
Build Bot
Comment 13 2015-09-03 12:03:48 PDT
Created attachment 260507 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Tim Horton
Comment 14 2015-09-03 13:26:04 PDT
Created attachment 260515 [details] Patch
WebKit Commit Bot
Comment 15 2015-09-03 13:29:34 PDT
Attachment 260515 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:95: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 16 2015-09-03 14:04:21 PDT
Comment on attachment 260515 [details] Patch Attachment 260515 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/137437 New failing tests: swipe/basic-cached-back-swipe.html
Build Bot
Comment 17 2015-09-03 14:04:26 PDT
Created attachment 260520 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Tim Horton
Comment 18 2015-09-03 14:12:26 PDT
http://trac.webkit.org/changeset/189287
Radar WebKit Bug Importer
Comment 19 2024-07-17 12:27:43 PDT
<rdar://problem/131945393>
Note You need to log in before you can comment on or make changes to this bug.