Bug 148679

Summary: Web Inspector: protocol generator should not allow non-boolean values for "optional" key
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147664
Bug Depends on:    
Bug Blocks: 147067    
Attachments:
Description Flags
Proposed Fix none

Description BJ Burg 2015-09-01 08:50:00 PDT 
Whoops
Comment 1 Radar WebKit Bug Importer 2015-09-01 08:50:49 PDT 
<rdar://problem/22518956>
Comment 2 BJ Burg 2015-09-01 11:18:39 PDT 
Created attachment 260375 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2015-09-01 11:20:37 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Joseph Pecoraro 2015-09-01 11:22:42 PDT 
Comment on attachment 260375 [details]
Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2015-09-01 11:45:20 PDT 
Comment on attachment 260375 [details]
Proposed Fix

Clearing flags on attachment: 260375

Committed r189222: <http://trac.webkit.org/changeset/189222>
Comment 6 WebKit Commit Bot 2015-09-01 11:45:24 PDT 
All reviewed patches have been landed.  Closing bug.