| Summary: | [ES6] Tail call fast path should efficiently reuse the frame's stack space | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basile Clement <basile_clement> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, msaboff | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 148334, 148335, 148337, 148448, 148661 | ||||||||||||||
| Bug Blocks: | 148663 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Basile Clement
2015-08-31 17:51:29 PDT
Created attachment 260626 [details]
Patch
Created attachment 261344 [details]
Rebased patch
Attachment 261344 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:604: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:627: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:648: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 4 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 261360 [details]
Patch with fix for 32 bit debug build
Attachment 261360 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:604: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:627: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:648: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 4 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 261368 [details]
Patch with speculative build fixes
Attachment 261368 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:42: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:604: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:627: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:648: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 4 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 261368 [details] Patch with speculative build fixes View in context: https://bugs.webkit.org/attachment.cgi?id=261368&action=review r=me > Source/JavaScriptCore/jit/CallFrameShuffler.h:45 > +class CachedRecovery { Please move this class to its own file. Created attachment 261533 [details]
Patch for Landing (and EWS testing)
Attachment 261533 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/jit/CachedRecovery.cpp:34: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.cpp:43: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:507: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:530: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/jit/CallFrameShuffler.h:551: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 6 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r189999: <http://trac.webkit.org/changeset/189999> |