Bug 148660

Summary:

[Cocoa] Testing: Allow overriding the system language for language-dependent tests

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Tools / Tests

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

andersca, ap

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mmaxfield: review-

Description Myles C. Maxfield 2015-08-31 17:19:06 PDT

[Cocoa] Testing: Allow overriding the system language for language-dependent tests

Comment 1 Myles C. Maxfield 2015-08-31 17:19:27 PDT

Created attachment 260340 [details]
Patch

Comment 2 Myles C. Maxfield 2015-08-31 17:38:53 PDT

Comment on attachment 260340 [details]
Patch

This should be done inside WebKitTestRunner

Comment 3 Alexey Proskuryakov 2015-08-31 22:05:10 PDT

Comment on attachment 260340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260340&action=review

> Tools/Scripts/webkitpy/port/base.py:532
> +            first_line = f.readline()

We probably need to allow having the metadata on the second line, because nothing can precede XML declaration.

Comment 4 Myles C. Maxfield 2015-08-31 23:16:50 PDT

Superseded by https://bugs.webkit.org/show_bug.cgi?id=148671