Bug 14861 – run-webkit-tests should link to Mac crash logs in results.html

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

patch coming

[Adam Roben (:aroben)]

Created attachment 15803 [details]
Patch with ChangeLog

[Mark Rowe (bdash)]

Comment on attachment 15803 [details]
Patch with ChangeLog

I think it would be preferable to not blow away crash logs permanently.  Perhaps they could be renamed in some way such that we don't see them in the future, or we could only look at the newest log?  Having the crash logs around long-term can be useful for various purposes.

[Eric Seidel (no email)]

*** Bug 30136 has been marked as a duplicate of this bug. ***

[Adam Roben (:aroben)]

Once bug 53718 is fixed, all that needs to be done is to add a case for Mac to the captureSavedCrashLog function.

[Eric Seidel (no email)]

Chromium already does something like this for their builds under NRWT (or at least I think they do).

Once this is added, the commit-queue will automatically include crash reports when reporting flaky crash tests. :)

[Adam Roben (:aroben)]

Created attachment 81224 [details]
Link to Mac crash logs from results.html

[David Kilzer (:ddkilzer)]

Comment on attachment 81224 [details]
Link to Mac crash logs from results.html

View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review

r=me!

> Tools/Scripts/old-run-webkit-tests:1763
> +        if (my @reportCrashPIDs = sort map { /^\s*(\d+)/; $1 } grep { /ReportCrash/ } `ps x`) {

Nit:  I prefer to use "/bin/ps" instead of just "ps", but it only matters if more than one 'ps' is installed in the path (e.g., by an attacker or MacPorts).

[Adam Roben (:aroben)]

Committed r77633: <http://trac.webkit.org/changeset/77633>

[Eric Seidel (no email)]

Comment on attachment 81224 [details]
Link to Mac crash logs from results.html

View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review

> Tools/Scripts/old-run-webkit-tests:1759
> +        $glob = File::Spec->catfile("~", "Library", "Logs", "CrashReporter", $dumpToolName . "_*.crash");

The location is OS version dependent.  So I think we'll need to tweak this for Leopard and Tiger (and possibly Lion).

[Adam Roben (:aroben)]

(In reply to comment #9)
> (From update of attachment 81224 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review
> 
> > Tools/Scripts/old-run-webkit-tests:1759
> > +        $glob = File::Spec->catfile("~", "Library", "Logs", "CrashReporter", $dumpToolName . "_*.crash");
> 
> The location is OS version dependent.  So I think we'll need to tweak this for Leopard and Tiger (and possibly Lion).

Be my guest! I just did what works on SnowLeopard, as I didn't have Leopard and Tiger available for testing.