[GTK] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer

• Component: New Bugs
• Status: RESOLVED FIXED

[Philip Chimento]

[GTK] [Stable] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer

[Philip Chimento]

Created attachment 260212 [details]
Patch

[Philip Chimento]

Comment on attachment 260212 [details]
Patch

Add a stub for the InstallMissingMediaPluginsPermissionRequest class for the case when video is disabled or not using GStreamer. It's OK that this class does nothing, because the associated C API contains an assert_not_reached if video is disabled. We just need to define the symbol so that the function signature will compile.

I'll add this to the proposed merges for 2.9.92.

[Michael Catanzaro]

FYI: we use [Stable] to indicate a patch that should not be committed to master (so it should not be used in combination with commit-queue).

[Philip Chimento]

OK, thanks for explaining. I meant this patch to be for both master and stable.

My confusion arose because the instructions on http://trac.webkit.org/wiki/WebKitGTK/2.10.x say to use "[GTK] [Stable]" so I'll add a note there explaining what you just told me.

[Michael Catanzaro]

Since this is a build fix, any committer can approve it, so if you attach a new patch with the "Reviewed by NOBODOY" line replaced with "Unreviewed" and request only commit-queue? but not review?, I will grant that.

[Philip Chimento]

Created attachment 264118 [details]
Patch

Thank you here as well!

[WebKit Commit Bot]

Comment on attachment 264118 [details]
Patch

Clearing flags on attachment: 264118

Committed r191618: <http://trac.webkit.org/changeset/191618>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.