Bug 148595

Summary: Refactor the JIT printer out of the AbstractMacroAssembler into MacroAssemblerPrinter.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the fix.
none
fix 2: remove those accidental newlines in VC project files. ggaren: review+

Description Mark Lam 2015-08-28 15:49:35 PDT 
Why do this?
1. MacroAssembler::print() code (except for the prototype) need no longer be parsed when compiling C++ files that don't need it.
2. Adding support for more printable types to MacroAssemblerPrinter::PrintArg triggers recompilation of less files.
3. The printing code is for most the part common between all target platforms and was previously duplicated by cut-and-paste to all the varieties of MacroAssemblers that support the MASM_PROBE mechanism.  Now, there is only one copy in MacroAssemblerPrinter.
Comment 1 Mark Lam 2015-08-28 15:51:42 PDT 
Created attachment 260187 [details]
the fix.
Comment 2 Mark Lam 2015-08-28 15:54:06 PDT 
Created attachment 260188 [details]
fix 2: remove those accidental newlines in VC project files.
Comment 3 Geoffrey Garen 2015-08-28 15:55:22 PDT 
Comment on attachment 260188 [details]
fix 2: remove those accidental newlines in VC project files.

r=me
Comment 4 Mark Lam 2015-08-28 15:59:46 PDT 
Thanks for the review.  Landed in r189130: <http://trac.webkit.org/r189130>.