Bug 148570

Summary: [GTK] Simplify the internal API to create a WebView
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, mcatanzaro, mrobinson, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2015-08-28 03:37:42 PDT
Now that all the information required to create a WebView is in API::PageConfiguration, we can simplify the internal API to receive only the configuration instead of receiving a long list of parameters that we use to build a new API::PageConfiguration.
Comment 1 Carlos Garcia Campos 2015-08-28 03:40:44 PDT
Created attachment 260145 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-28 03:41:23 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2015-08-28 03:55:23 PDT
Comment on attachment 260145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260145&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1050
> +    Ref<API::PageConfiguration> copiedConfiguration = configuration.copy();
> +    webkitWebViewBaseCreateWebPage(webkitWebViewBase, WTF::move(copiedConfiguration));

Can be just:

    webkitWebViewBaseCreateWebPage(webkitWebViewBase, configuration.copy());
Comment 4 Carlos Garcia Campos 2015-08-28 04:16:32 PDT
Committed r189094: <http://trac.webkit.org/changeset/189094>