Summary: | [GTK] Simplify the internal API to create a WebView | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, commit-queue, gustavo, mcatanzaro, mrobinson, zan | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-08-28 03:37:42 PDT
Created attachment 260145 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 260145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260145&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1050 > + Ref<API::PageConfiguration> copiedConfiguration = configuration.copy(); > + webkitWebViewBaseCreateWebPage(webkitWebViewBase, WTF::move(copiedConfiguration)); Can be just: webkitWebViewBaseCreateWebPage(webkitWebViewBase, configuration.copy()); Committed r189094: <http://trac.webkit.org/changeset/189094> |