Bug 148539

Summary: [Win CMake] Fix incremental build after r188673
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Alex Christensen
Reported 2015-08-27 14:19:31 PDT
Using CMake's file(COPY ...) copies files only when CMake is run, which is only when a CMakeLists.txt or PlatformWin.cmake is touched. When a header is changed but no files are added or removed, it breaks the incremental build. Using xcopy as a build step solves this.
Attachments
Patch (7.23 KB, patch)
2015-08-27 14:24 PDT, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-08-27 14:24:20 PDT
Created attachment 260088 [details] Patch
Brent Fulgham
Comment 2 2015-08-27 14:29:10 PDT
Comment on attachment 260088 [details] Patch r=me
Alex Christensen
Comment 3 2015-08-27 14:32:05 PDT
r189055
Note You need to log in before you can comment on or make changes to this bug.