Bug 148535

Summary:

The status message for combined builder queues should say "all builds passed" if everything built correctly.

Product:

WebKit

Reporter:

Jason Marcell <jmarcell>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, ap, bburg, commit-queue, dbates, dean_johnson, jake.nielsen.webkit, jmarcell

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=153882

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Jason Marcell

Reported 2015-08-27 11:40:51 PDT

The status message for combined builder queues should say "all builds passed" if everything built correctly.

Attachments
Patch (2.08 KB, patch) 2015-08-27 11:43 PDT, Jason Marcell	no flags	Details Formatted Diff Diff
Patch (2.11 KB, patch) 2015-08-27 17:22 PDT, Jason Marcell	no flags	Details Formatted Diff Diff
Patch (2.16 KB, patch) 2015-08-28 10:47 PDT, Jason Marcell	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jason Marcell

Comment 1 2015-08-27 11:43:41 PDT

Created attachment 260073 [details] Patch

David Kilzer (:ddkilzer)

Comment 2 2015-08-27 16:57:34 PDT

Comment on attachment 260073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260073&action=review r=me if you fix the nit. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:90 > + var statusMessagePassed = "all " + (queue.builder ? "builds" : "tests") + " passed" Nit: This should have a semi-colon at the end of the line.

Jason Marcell

Comment 3 2015-08-27 17:22:32 PDT

Created attachment 260099 [details] Patch

David Kilzer (:ddkilzer)

Comment 4 2015-08-27 17:33:02 PDT

Comment on attachment 260099 [details] Patch r=me

Alexey Proskuryakov

Comment 5 2015-08-28 08:58:22 PDT

This should probably be "all builds succeeded", not "all builds passed".

Jason Marcell

Comment 6 2015-08-28 10:47:17 PDT

Created attachment 260163 [details] Patch