| Summary: | The status message for combined builder queues should say "all builds passed" if everything built correctly. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jason Marcell <jmarcell> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | adele, ap, bburg, commit-queue, dbates, dean_johnson, jake.nielsen.webkit, jmarcell | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=153882 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jason Marcell
2015-08-27 11:40:51 PDT
Created attachment 260073 [details]
Patch
Comment on attachment 260073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260073&action=review r=me if you fix the nit. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:90 > + var statusMessagePassed = "all " + (queue.builder ? "builds" : "tests") + " passed" Nit: This should have a semi-colon at the end of the line. Created attachment 260099 [details]
Patch
Comment on attachment 260099 [details]
Patch
r=me
This should probably be "all builds succeeded", not "all builds passed". Created attachment 260163 [details]
Patch
Comment on attachment 260163 [details] Patch Clearing flags on attachment: 260163 Committed r189106: <http://trac.webkit.org/changeset/189106> All reviewed patches have been landed. Closing bug. |