Bug 148528

Summary:

REGRESSION(r188548): TestController state is Resseting while tests are running after r188548

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, darin, ossy, sam

Priority:

Keywords:

Regression

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148093, 148529

Attachments:

Description	Flags
Patch	none

Description Carlos Garcia Campos 2015-08-27 08:43:55 PDT

Before r188548 resetStateToConsistentValues() was called in TestController::run(), before tests are run, but now it's called for every test in TestInvocation::invoke(), after m_status has changed to RunningTest.

Comment 1 Carlos Garcia Campos 2015-08-27 08:46:05 PDT

Created attachment 260057 [details]
Patch

Comment 2 WebKit Commit Bot 2015-09-02 01:27:40 PDT

Comment on attachment 260057 [details]
Patch

Rejecting attachment 260057 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260057, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/132367

Comment 3 Csaba Osztrogonác 2015-09-02 05:01:05 PDT

Comment on attachment 260057 [details]
Patch

Clearing flags on attachment: 260057

Committed r189245: <http://trac.webkit.org/changeset/189245>

Comment 4 Csaba Osztrogonác 2015-09-02 05:01:15 PDT

All reviewed patches have been landed.  Closing bug.