Bug 148522

Summary: [GStreamer] Cleanup the iradio properties
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, slomo, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch pnormand: review+

Carlos Garcia Campos
Reported 2015-08-27 03:45:38 PDT
We could use CString instead of char* to avoid all the g_strdup()/g_free().
Attachments
Patch (8.27 KB, patch)
2015-08-27 03:47 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (8.02 KB, patch)
2015-11-02 08:52 PST, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-08-27 03:47:29 PDT
Created attachment 260050 [details] Patch
Philippe Normand
Comment 2 2015-08-27 03:52:06 PDT
Sebastian, why are these iradio properties needed? I always wondered about this :)
Sebastian Dröge (slomo)
Comment 3 2015-08-27 04:09:45 PDT
0.10 crap :) The properties except for iradio-mode can definitely go away as long as the things are also posted as tags on the bus. iradio-mode might be useful if you want to disable sending that special HTTP header to servers. There might be some confused by it, who knows.
Carlos Garcia Campos
Comment 4 2015-11-02 08:52:10 PST
Created attachment 264592 [details] Patch Is this better then?
Philippe Normand
Comment 5 2015-11-03 01:49:17 PST
Comment on attachment 264592 [details] Patch Nice :)
Carlos Garcia Campos
Comment 6 2015-11-03 02:41:05 PST
Committed r191947: <http://trac.webkit.org/changeset/191947>
Note You need to log in before you can comment on or make changes to this bug.