Bug 148490

Summary: Use WorkQueue::concurrentApply in FEConvolveMatrix
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148497    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Anders Carlsson
Reported 2015-08-26 12:57:55 PDT
Use WorkQueue::concurrentApply in FEConvolveMatrix
Attachments
Patch (6.63 KB, patch)
2015-08-26 13:02 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (7.20 KB, patch)
2015-08-26 13:25 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-08-26 13:02:41 PDT
Created attachment 259972 [details] Patch
Anders Carlsson
Comment 2 2015-08-26 13:25:29 PDT
Created attachment 259974 [details] Patch
Anders Carlsson
Comment 3 2015-08-26 13:44:19 PDT
Committed r188987: <http://trac.webkit.org/changeset/188987>
Said Abou-Hallawa
Comment 4 2015-08-26 13:54:20 PDT
Comment on attachment 259974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259974&action=review > Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:459 > + }); If chunkCount == 1, should not we fallback to single thread mode?
Anders Carlsson
Comment 5 2015-08-26 14:03:29 PDT
Comment on attachment 259974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259974&action=review >> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:459 >> + }); > > If chunkCount == 1, should not we fallback to single thread mode? WorkQueue::concurrentApply does that.
Andy Estes
Comment 6 2015-08-26 17:06:08 PDT
This caused imported/mozilla/svg/filters/feConvolveMatrix-1.svg to start failing. See <https://bugs.webkit.org/show_bug.cgi?id=148497> for details.
Alexey Proskuryakov
Comment 7 2015-08-27 11:34:47 PDT
As this broke a test, do we want to keep this in, or to roll out?
Anders Carlsson
Comment 8 2015-08-27 11:49:51 PDT
(In reply to comment #7) > As this broke a test, do we want to keep this in, or to roll out? Looking at it.
Note You need to log in before you can comment on or make changes to this bug.