Summary: | Use WorkQueue::concurrentApply in FEConvolveMatrix | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 148497 | ||||||||
Attachments: |
|
Description
Anders Carlsson
2015-08-26 12:57:55 PDT
Created attachment 259972 [details]
Patch
Created attachment 259974 [details]
Patch
Committed r188987: <http://trac.webkit.org/changeset/188987> Comment on attachment 259974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259974&action=review > Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:459 > + }); If chunkCount == 1, should not we fallback to single thread mode? Comment on attachment 259974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259974&action=review >> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:459 >> + }); > > If chunkCount == 1, should not we fallback to single thread mode? WorkQueue::concurrentApply does that. This caused imported/mozilla/svg/filters/feConvolveMatrix-1.svg to start failing. See <https://bugs.webkit.org/show_bug.cgi?id=148497> for details. As this broke a test, do we want to keep this in, or to roll out? (In reply to comment #7) > As this broke a test, do we want to keep this in, or to roll out? Looking at it. |