Bug 148490

Summary: Use WorkQueue::concurrentApply in FEConvolveMatrix
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148497    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Anders Carlsson 2015-08-26 12:57:55 PDT 
Use WorkQueue::concurrentApply in FEConvolveMatrix
Comment 1 Anders Carlsson 2015-08-26 13:02:41 PDT 
Created attachment 259972 [details]
Patch
Comment 2 Anders Carlsson 2015-08-26 13:25:29 PDT 
Created attachment 259974 [details]
Patch
Comment 3 Anders Carlsson 2015-08-26 13:44:19 PDT 
Committed r188987: <http://trac.webkit.org/changeset/188987>
Comment 4 Said Abou-Hallawa 2015-08-26 13:54:20 PDT 
Comment on attachment 259974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259974&action=review

> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:459
> +    });

If chunkCount == 1, should not we fallback to single thread mode?
Comment 5 Anders Carlsson 2015-08-26 14:03:29 PDT 
Comment on attachment 259974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259974&action=review

>> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:459
>> +    });
> 
> If chunkCount == 1, should not we fallback to single thread mode?

WorkQueue::concurrentApply does that.
Comment 6 Andy Estes 2015-08-26 17:06:08 PDT 
This caused imported/mozilla/svg/filters/feConvolveMatrix-1.svg to start failing. See <https://bugs.webkit.org/show_bug.cgi?id=148497> for details.
Comment 7 Alexey Proskuryakov 2015-08-27 11:34:47 PDT 
As this broke a test, do we want to keep this in, or to roll out?
Comment 8 Anders Carlsson 2015-08-27 11:49:51 PDT 
(In reply to comment #7)
> As this broke a test, do we want to keep this in, or to roll out?

Looking at it.