Bug 148478

Summary: [JSC] StructureTransitionTable should eagerly deallocate single-transition WeakImpls.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-08-26 08:28:52 PDT
When using the single-transition optimization, StructureTransitionTable sometimes holds on to a WeakImpl after its pointee has been collected. This causes us to unnecessarily extend the lifetime of WeakBlocks.
Attachments
Patch (4.94 KB, patch)
2015-08-26 08:42 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-08-26 08:42:53 PDT
Created attachment 259953 [details] Patch
Geoffrey Garen
Comment 2 2015-08-26 11:01:55 PDT
Comment on attachment 259953 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-08-26 12:21:35 PDT
Comment on attachment 259953 [details] Patch Clearing flags on attachment: 259953 Committed r188978: <http://trac.webkit.org/changeset/188978>
WebKit Commit Bot
Comment 4 2015-08-26 12:21:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.