Bug 148478

Summary:

[JSC] StructureTransitionTable should eagerly deallocate single-transition WeakImpls.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren

Priority:

Keywords:

Performance

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2015-08-26 08:28:52 PDT

When using the single-transition optimization, StructureTransitionTable sometimes holds on to a WeakImpl after its pointee has been collected.
This causes us to unnecessarily extend the lifetime of WeakBlocks.

Comment 1 Andreas Kling 2015-08-26 08:42:53 PDT

Created attachment 259953 [details]
Patch

Comment 2 Geoffrey Garen 2015-08-26 11:01:55 PDT

Comment on attachment 259953 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2015-08-26 12:21:35 PDT

Comment on attachment 259953 [details]
Patch

Clearing flags on attachment: 259953

Committed r188978: <http://trac.webkit.org/changeset/188978>

Comment 4 WebKit Commit Bot 2015-08-26 12:21:38 PDT

All reviewed patches have been landed.  Closing bug.