Bug 148437

Summary: prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
Product: WebKit Reporter: Paul Hankes Drielsma <hankesdrielsma>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Minor CC: cgarcia, dbates, ddkilzer, mcatanzaro, slewis
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159067
Bug Depends on: 160924    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Paul Hankes Drielsma
Reported 2015-08-25 11:20:31 PDT
I have a purely subtractive patch that touches many methods in two Objective-C++ file. In each method, I removed one or two lines. prepare-ChangeLog is listing all of those methods as having been deleted. Possibly related to or a duplicate of https://bugs.webkit.org/show_bug.cgi?id=137889 or https://bugs.webkit.org/show_bug.cgi?id=144829
Attachments
Patch (17.75 KB, patch)
2016-08-16 18:46 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-08-16 18:26:14 PDT
*** Bug 159067 has been marked as a duplicate of this bug. ***
Daniel Bates
Comment 2 2016-08-16 18:46:19 PDT
Created attachment 286246 [details] Patch
Daniel Bates
Comment 3 2016-08-16 19:44:37 PDT
*** Bug 159067 has been marked as a duplicate of this bug. ***
Daniel Bates
Comment 4 2016-08-21 11:10:07 PDT
Comment on attachment 286246 [details] Patch Clearing flags on attachment: 286246 Committed r204695: <http://trac.webkit.org/changeset/204695>
Daniel Bates
Comment 5 2016-08-21 11:10:11 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 6 2016-08-25 09:24:11 PDT
It broke webkit-perl test for GTK in a rather wild way. Why's it trying to exec /usr/bin/non-existent-command? Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl ........................................... 1/3 Can't exec "/usr/bin/non-existent-command": No such file or directory at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/VCSUtils.pm line 2298. Failed to exec(): No such file or directory at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/VCSUtils.pm line 2298.
Daniel Bates
Comment 7 2016-08-25 09:41:17 PDT
(In reply to comment #6) > It broke webkit-perl test for GTK in a rather wild way. Why's it trying to > exec /usr/bin/non-existent-command? > > Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl > ........................................... 1/3 Can't exec > "/usr/bin/non-existent-command": No such file or directory at > /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/ > VCSUtils.pm line 2298. > Failed to exec(): No such file or directory at > /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/ > VCSUtils.pm line 2298. Notice that this message occurred before <http://trac.webkit.org/changeset/204695>: <https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/10600/steps/webkitperl-test/logs/stdio>.
Daniel Bates
Comment 8 2016-08-25 09:42:51 PDT
Looking at the latest GTK results I see the following error: [[ Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl ....................... Can't locate File/Slurp.pm in @INC (you may need to install the File::Slurp module) (@INC contains: /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/Tools/Scripts /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl line 28. BEGIN failed--compilation aborted at Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl line 28. ]] <https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/10792/steps/webkitperl-test/logs/stdio>
Daniel Bates
Comment 9 2016-08-25 09:56:57 PDT
(In reply to comment #8) > Looking at the latest GTK results I see the following error: > > [[ > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl > ....................... Can't locate File/Slurp.pm in @INC (you may need to > install the File::Slurp module) (@INC contains: > /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/Tools/Scripts /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 > /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 > /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 > /usr/local/lib/site_perl .) at > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl > line 28. > BEGIN failed--compilation aborted at > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl > line 28. > ]] > <https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Debug%20%28Tests%29/builds/10792/steps/webkitperl-test/logs/stdio> Committed fix in <http://trac.webkit.org/changeset/204969>.
Note You need to log in before you can comment on or make changes to this bug.