I have a purely subtractive patch that touches many methods in two Objective-C++ file. In each method, I removed one or two lines. prepare-ChangeLog is listing all of those methods as having been deleted. Possibly related to or a duplicate of https://bugs.webkit.org/show_bug.cgi?id=137889 or https://bugs.webkit.org/show_bug.cgi?id=144829
*** Bug 159067 has been marked as a duplicate of this bug. ***
Created attachment 286246 [details] Patch
Comment on attachment 286246 [details] Patch Clearing flags on attachment: 286246 Committed r204695: <http://trac.webkit.org/changeset/204695>
All reviewed patches have been landed. Closing bug.
It broke webkit-perl test for GTK in a rather wild way. Why's it trying to exec /usr/bin/non-existent-command? Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl ........................................... 1/3 Can't exec "/usr/bin/non-existent-command": No such file or directory at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/VCSUtils.pm line 2298. Failed to exec(): No such file or directory at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/VCSUtils.pm line 2298.
(In reply to comment #6) > It broke webkit-perl test for GTK in a rather wild way. Why's it trying to > exec /usr/bin/non-existent-command? > > Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl > ........................................... 1/3 Can't exec > "/usr/bin/non-existent-command": No such file or directory at > /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/ > VCSUtils.pm line 2298. > Failed to exec(): No such file or directory at > /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/ > VCSUtils.pm line 2298. Notice that this message occurred before <http://trac.webkit.org/changeset/204695>: <https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/10600/steps/webkitperl-test/logs/stdio>.
Looking at the latest GTK results I see the following error: [[ Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl ....................... Can't locate File/Slurp.pm in @INC (you may need to install the File::Slurp module) (@INC contains: /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/Tools/Scripts /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl line 28. BEGIN failed--compilation aborted at Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl line 28. ]] <https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/10792/steps/webkitperl-test/logs/stdio>
(In reply to comment #8) > Looking at the latest GTK results I see the following error: > > [[ > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl > ....................... Can't locate File/Slurp.pm in @INC (you may need to > install the File::Slurp module) (@INC contains: > /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/Tools/Scripts /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 > /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 > /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 > /usr/local/lib/site_perl .) at > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl > line 28. > BEGIN failed--compilation aborted at > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl > line 28. > ]] > <https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Debug%20%28Tests%29/builds/10792/steps/webkitperl-test/logs/stdio> Committed fix in <http://trac.webkit.org/changeset/204969>.