| Summary: | Web Inspector: Styles sidebar says Media: all when it should say Media: screen | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 260943 [details]
Patch
Comment on attachment 260943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260943&action=review r=me > Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:193 > + var currentMediaList = style.ownerRule && style.ownerRule.mediaList; This change removes the fallback to [] if both are null. Maybe you should add || [] ? (In reply to comment #3) > This change removes the fallback to [] if both are null. Maybe you should > add || [] ? It shouldn't be an issue when both are null, but I can see an issue when only one is null and the other isn't. I'll add that now. Created attachment 260944 [details]
Patch
Comment on attachment 260944 [details] Patch Clearing flags on attachment: 260944 Committed r189593: <http://trac.webkit.org/changeset/189593> All reviewed patches have been landed. Closing bug. |
Created attachment 259860 [details] Screenshot On daring fireball.net, the stylesheets are media="screen", however the sidebar says Media: all. The Copy Rule context menu does include the media as screen, so the data is there we are just showing the wrong thing.