Bug 148431

Summary: [Win] Build does not generate debug info.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148452    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2015-08-25 07:34:47 PDT 
For debugging purposes, it would be nice to have debug info :)
Comment 1 peavo 2015-08-25 07:54:08 PDT 
Created attachment 259844 [details]
Patch
Comment 2 Brent Fulgham 2015-08-25 09:25:50 PDT 
Comment on attachment 259844 [details]
Patch

Whoops!  r=me.
Comment 3 peavo 2015-08-25 10:03:32 PDT 
(In reply to comment #2)
> Comment on attachment 259844 [details]
> Patch
> 
> Whoops!  r=me.

Thanks :)
Comment 4 WebKit Commit Bot 2015-08-25 11:02:13 PDT 
Comment on attachment 259844 [details]
Patch

Clearing flags on attachment: 259844

Committed r188919: <http://trac.webkit.org/changeset/188919>
Comment 5 WebKit Commit Bot 2015-08-25 11:02:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2015-08-25 13:24:16 PDT 
(In reply to comment #4)
> Comment on attachment 259844 [details]
> Patch
> 
> Clearing flags on attachment: 259844
> 
> Committed r188919: <http://trac.webkit.org/changeset/188919>

It broke the WinCairo build:
fatal error RC1212: invalid option - /z argument missing substitute font name
Comment 7 WebKit Commit Bot 2015-08-25 16:38:42 PDT 
Re-opened since this is blocked by bug 148452
Comment 8 peavo 2015-08-26 08:46:57 PDT 
Created attachment 259954 [details]
Patch
Comment 9 peavo 2015-08-26 08:47:30 PDT 
Sorry for the compile issue, trying again ;)
Comment 10 peavo 2015-08-26 11:13:13 PDT 
Thanks for reviewing, let's hope it builds this time :)
Comment 11 WebKit Commit Bot 2015-08-26 11:50:22 PDT 
Comment on attachment 259954 [details]
Patch

Clearing flags on attachment: 259954

Committed r188974: <http://trac.webkit.org/changeset/188974>
Comment 12 WebKit Commit Bot 2015-08-26 11:50:26 PDT 
All reviewed patches have been landed.  Closing bug.