Bug 148431 - [Win] Build does not generate debug info.
Summary: [Win] Build does not generate debug info.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 148452
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-25 07:34 PDT by peavo
Modified: 2015-08-26 11:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2015-08-25 07:54 PDT, peavo 		no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2015-08-26 08:46 PDT, peavo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-08-25 07:34:47 PDT 
For debugging purposes, it would be nice to have debug info :)
Comment 1 peavo 2015-08-25 07:54:08 PDT 
Created attachment 259844 [details]
Patch
Comment 2 Brent Fulgham 2015-08-25 09:25:50 PDT 
Comment on attachment 259844 [details]
Patch

Whoops!  r=me.
Comment 3 peavo 2015-08-25 10:03:32 PDT 
(In reply to comment #2)
> Comment on attachment 259844 [details]
> Patch
> 
> Whoops!  r=me.

Thanks :)
Comment 4 WebKit Commit Bot 2015-08-25 11:02:13 PDT 
Comment on attachment 259844 [details]
Patch

Clearing flags on attachment: 259844

Committed r188919: <http://trac.webkit.org/changeset/188919>
Comment 5 WebKit Commit Bot 2015-08-25 11:02:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2015-08-25 13:24:16 PDT 
(In reply to comment #4)
> Comment on attachment 259844 [details]
> Patch
> 
> Clearing flags on attachment: 259844
> 
> Committed r188919: <http://trac.webkit.org/changeset/188919>

It broke the WinCairo build:
fatal error RC1212: invalid option - /z argument missing substitute font name
Comment 7 WebKit Commit Bot 2015-08-25 16:38:42 PDT 
Re-opened since this is blocked by bug 148452
Comment 8 peavo 2015-08-26 08:46:57 PDT 
Created attachment 259954 [details]
Patch
Comment 9 peavo 2015-08-26 08:47:30 PDT 
Sorry for the compile issue, trying again ;)
Comment 10 peavo 2015-08-26 11:13:13 PDT 
Thanks for reviewing, let's hope it builds this time :)
Comment 11 WebKit Commit Bot 2015-08-26 11:50:22 PDT 
Comment on attachment 259954 [details]
Patch

Clearing flags on attachment: 259954

Committed r188974: <http://trac.webkit.org/changeset/188974>
Comment 12 WebKit Commit Bot 2015-08-26 11:50:26 PDT 
All reviewed patches have been landed.  Closing bug.